Fix a memory leak in Flutter (#148291) | Building Flutter

Published 2024-06-22

All Comments (21)
  • @aytunch
    Perfect real time contribution from investigation to PR. You deserve to be sponsored by many more of us!
  • This is insane ! How have I not heard about this channel before. Keep it up
  • @Elguri-yk7rb
    I want to see more of this kind of educational videos
  • That's awesome work you are doing, lots of learning here, keep it up.
  • @verticrow
    Really awesome to see the whole process! Thanks for all that you do.
  • @mattlampe
    This was very cool to watch, I've made some contributions to packages I've changed/fixed before and that always feels really cool, but this made fixing something in the flutter framework feel more approachable as it always seemed so daunting before. Thanks for making this video!
  • @ShawnBlais
    Seems like you just didn't register that value is a `ValueNotifier` and it's updated in `onTriggered`. So it's totally expected that you couldn't find anywhere where it updates the value internally. By design it defers to `onTriggered` to set the value, and the widget uses `notifier.addListener` to act on those changes.
  • @mkc11267
    Learned a lot! I hope I which I could sponsor you but I currently have no work lol. But please continue publishing videos including in your other channel. Your contents are literally diamonds in flutter community.
  • Awsome video. Learned a lot from this. Will you be doing Live Streams in the future?
  • @theGoldyMan
    I felt like Mr Carroll was at the bring of saying some slurs. I was at least. That was a good experience watching this process. Decoding the source of some part of flutter is just madness, I feel we are missing a huge chunk of information about the context in which this feature was developed. Wasn't there a design doc? You have my respect since the times before you deleted your flutter challenges, I miss them so much. Keep up the good work. Thanks a lot for this video.
  • @maherov1930
    I don't believe that you need to remove the history of undo redo if the widget lost focus , but only if it is disposed.....if we write in text field some texts and then jumped to another one, in your case we can not redo anything right? I hope you got my points cuz English is my second language
  • @britannio
    Could you use git interactive staging (git add -p) to avoid committing the formatting changes?